Skip to content

Commit

Permalink
fix typo of 'not' instead of 'now' for useInheritedMediaQuery (flut…
Browse files Browse the repository at this point in the history
…ter#139940)

The doc comment for `useInheritedMediaQuery` has a typo of 'not' instead of 'now' and it is confusing at the `@Deprecated()` message clearly states it is *now* ignored.
(and indeed checking the code you can verify that it *is* indeed ignored)

existing code before PR:
```dart
/// {@template flutter.widgets.widgetsApp.useInheritedMediaQuery}
/// Deprecated. This setting is not ignored.
///                             ^^^
/// The widget never introduces its own [MediaQuery]; the [View] widget takes
/// care of that.
/// {@endtemplate}
@deprecated(
  'This setting is now ignored. '
  'WidgetsApp never introduces its own MediaQuery; the View widget takes care of that. '
  'This feature was deprecated after v3.7.0-29.0.pre.'
)
final bool useInheritedMediaQuery;
```

- [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • Loading branch information
timmaffett committed Dec 11, 2023
1 parent 0f7ac29 commit 2b3a16b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/flutter/lib/src/widgets/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,7 @@ class WidgetsApp extends StatefulWidget {
final String? restorationScopeId;

/// {@template flutter.widgets.widgetsApp.useInheritedMediaQuery}
/// Deprecated. This setting is not ignored.
/// Deprecated. This setting is now ignored.
///
/// The widget never introduces its own [MediaQuery]; the [View] widget takes
/// care of that.
Expand Down

0 comments on commit 2b3a16b

Please sign in to comment.