chore: add ts-ignores for Deno.consoleSize() API (denoland#2808)

bartlomieju · Oct 25, 2022 · 91cebba · 91cebba
1 parent 4de657f
commit 91cebba
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/node/_process/streams.mjs b/node/_process/streams.mjs
@@ -42,6 +42,8 @@ function createWritableStdioStream(writer, name) {
       configurable: true,
       get: () =>
         Deno.isatty?.(writer?.rid)
+          // TODO(bartlomieju):
+          // @ts-ignore Deno.consoleSize is getting stabilized and its signature changes
           ? Deno.consoleSize?.(writer?.rid).columns
           : undefined,
     },
@@ -50,6 +52,8 @@ function createWritableStdioStream(writer, name) {
       configurable: true,
       get: () =>
         Deno.isatty?.(writer?.rid)
+          // TODO(bartlomieju):
+          // @ts-ignore Deno.consoleSize is getting stabilized and its signature changes
           ? Deno.consoleSize?.(writer?.rid).rows
           : undefined,
     },
@@ -63,6 +67,8 @@ function createWritableStdioStream(writer, name) {
       configurable: true,
       value: () =>
         Deno.isatty?.(writer?.rid)
+          // TODO(bartlomieju):
+          // @ts-ignore Deno.consoleSize is getting stabilized and its signature changes
           ? Object.values(Deno.consoleSize?.(writer?.rid))
           : undefined,
     },

diff --git a/node/process_test.ts b/node/process_test.ts
@@ -330,6 +330,8 @@ Deno.test({
     assertEquals(process.stdout.fd, Deno.stdout.rid);
     const isTTY = Deno.isatty(Deno.stdout.rid);
     assertEquals(process.stdout.isTTY, isTTY);
+    // TODO(bartlomieju):
+    // @ts-ignore Deno.consoleSize is getting stabilized and its signature changes
     const consoleSize = isTTY ? Deno.consoleSize(Deno.stdout.rid) : undefined;
     assertEquals(process.stdout.columns, consoleSize?.columns);
     assertEquals(process.stdout.rows, consoleSize?.rows);
@@ -358,6 +360,8 @@ Deno.test({
     assertEquals(process.stderr.fd, Deno.stderr.rid);
     const isTTY = Deno.isatty(Deno.stderr.rid);
     assertEquals(process.stderr.isTTY, isTTY);
+    // TODO(bartlomieju):
+    // @ts-ignore Deno.consoleSize is getting stabilized and its signature changes
     const consoleSize = isTTY ? Deno.consoleSize(Deno.stderr.rid) : undefined;
     assertEquals(process.stderr.columns, consoleSize?.columns);
     assertEquals(process.stderr.rows, consoleSize?.rows);