Allow usage with devise 4.x #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#51 should fix the test suite to get this passing with Travis. |
|
@cgunther There is a CVE with devise 4.5.0: heartcombo/devise#4981. Would it be possible to merge #51 and this PR and release a new version of this gem? |
|
Rebased and pushed. |
This was referenced Mar 21, 2019
Closed
|
Thanks for the merge/release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite passes locally with devise 4.6 and it works fine in my app with devise 4.6.
This is a bit more lenient than in the past by allowing any 4.x version of devise in hopes that this gem doesn't need a version bump every time devise releases a new minor version. The commits to add support for 4.2 (56c8eea), 4.3 (7acd880), 4.4 (6c4baaa), and 4.5 (8f5fd6a) all required no code changes as a result of the devise upgrade.