This repository has been archived by the owner on May 29, 2024. It is now read-only.
Markdown linting support #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alessandromazza98, thanks for the contribution! Once the failing checks pass, I'll go ahead and give this a +1 |
|
Now I get a golang-ci lint error but it's related to a file I did not change, which is |
|
@alessandromazza98 I see that, for some reason the last merged PR introduced this regression which for some reason wasn't detected in CI. Nonetheless I've put another PR in the meantime to fix this. Once this is merged you should be able to rebase and we'll be smooth sailing ⛵ |
alessandromazza98
force-pushed
the
markdownlint
branch
from
6641b41
to
7f5d0aa
Compare
|
Should be ok now |
epociask
approved these changes
Sep 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
I add
markdownlintsupport in CI with a config file.markdownlint.jsonin order to not display line length errors because I think they sometimes are necessary.I add in the
README.mdthe steps to lint md files so that there are no problems in CI.Let me know what do you think.
Thanks