Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

63 include custom filter in experimental #64

Merged
merged 10 commits into from
Aug 22, 2024
Merged

63 include custom filter in experimental #64

merged 10 commits into from
Aug 22, 2024

Conversation

frederik-sandfort1
Copy link
Collaborator

@frederik-sandfort1 frederik-sandfort1 commented Aug 15, 2024 •
edited
Loading

Please have a look @c-w-feldmann and @JochenSiegWork :-)

@frederik-sandfort1 frederik-sandfort1 linked an issue Aug 15, 2024 that may be closed by this pull request
Include custom filter in experimental #63
Closed
c-w-feldmann
c-w-feldmann requested changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@c-w-feldmann c-w-feldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

.vscode/settings.json Outdated Show resolved Hide resolved
tests/test_elements/test_experimental/__init__.py Outdated Show resolved Hide resolved
c-w-feldmann
c-w-feldmann reviewed Aug 16, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
JochenSiegWork
JochenSiegWork requested changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I have only small comments, mostly on the documentation.

.gitignore Outdated Show resolved Hide resolved
molpipeline/experimental/custom_filter.py Outdated Show resolved Hide resolved
molpipeline/experimental/custom_filter.py Show resolved Hide resolved
molpipeline/mol2any/mol2bool.py Outdated Show resolved Hide resolved
tests/test_elements/test_experimental/test_custom_filter.py Outdated Show resolved Hide resolved
@frederik-sandfort1 frederik-sandfort1 self-assigned this Aug 21, 2024
JochenSiegWork
JochenSiegWork approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these two minor changes it can be merged

.gitignore Outdated Show resolved Hide resolved
molpipeline/experimental/custom_filter.py Show resolved Hide resolved
JochenSiegWork
JochenSiegWork approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for merge 👍

@frederik-sandfort1 frederik-sandfort1 merged commit b18b78b into main Aug 22, 2024
14 checks passed
@c-w-feldmann c-w-feldmann deleted the 63-include-custom-filter-in-experimental branch August 22, 2024 13:46
@c-w-feldmann c-w-feldmann added the type: enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-w-feldmann c-w-feldmann c-w-feldmann approved these changes

@JochenSiegWork JochenSiegWork JochenSiegWork approved these changes

Assignees

@frederik-sandfort1 frederik-sandfort1

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include custom filter in experimental
3 participants
@frederik-sandfort1 @c-w-feldmann @JochenSiegWork