Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

81 postpredictionwrapper handle set params without wrapped estimator #82

Merged
merged 11 commits into from
Sep 27, 2024
Merged

81 postpredictionwrapper handle set params without wrapped estimator #82

merged 11 commits into from
Sep 27, 2024

Conversation

c-w-feldmann
Copy link
Collaborator

@c-w-feldmann c-w-feldmann commented Sep 5, 2024 •
edited
Loading

Fixes legacy behavior for get and set params.

@c-w-feldmann c-w-feldmann added the type: bug Something isn't working label Sep 5, 2024
@c-w-feldmann c-w-feldmann self-assigned this Sep 5, 2024
@c-w-feldmann c-w-feldmann linked an issue Sep 5, 2024 that may be closed by this pull request
PostPredictionWrapper: Handle set_params without 'wrapped_estimator' #81
Closed
@c-w-feldmann c-w-feldmann marked this pull request as ready for review September 5, 2024 16:18
JochenSiegWork
JochenSiegWork requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@JochenSiegWork JochenSiegWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. You should add a small unit test to test that the bug is actually fixed.

@c-w-feldmann
Copy link
Collaborator Author

looks good. You should add a small unit test to test that the bug is actually fixed.

Done

@c-w-feldmann c-w-feldmann added this to the v0.9.0 milestone Sep 23, 2024
JochenSiegWork
JochenSiegWork requested changes Sep 26, 2024
View reviewed changes
tests/test_elements/test_post_prediction.py Outdated Show resolved Hide resolved
tests/test_elements/test_post_prediction.py Show resolved Hide resolved
tests/test_elements/test_post_prediction.py Outdated Show resolved Hide resolved
tests/test_elements/test_post_prediction.py Outdated Show resolved Hide resolved
@c-w-feldmann c-w-feldmann merged commit d67807f into main Sep 27, 2024
14 checks passed
@c-w-feldmann c-w-feldmann deleted the 81-postpredictionwrapper-handle-set_params-without-wrapped_estimator branch September 27, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JochenSiegWork JochenSiegWork JochenSiegWork approved these changes

Assignees

@c-w-feldmann c-w-feldmann

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

PostPredictionWrapper: Handle set_params without 'wrapped_estimator'
2 participants
@c-w-feldmann @JochenSiegWork