Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension shows error on hovering #80

Closed
lamyergeier opened this issue Sep 23, 2018 · 14 comments
Closed

Extension shows error on hovering #80

lamyergeier opened this issue Sep 23, 2018 · 14 comments
Labels
question Further information is requested

Comments

@lamyergeier
Copy link

lamyergeier commented Sep 23, 2018

Hovering over 21:22
[Error - 10:43:37 PM] Request textDocument/hover failed.
  Message: Request textDocument/hover failed with message: Error: connect ECONNREFUSED 127.0.0.1:5000
  Code: -32603 

What should I do?

@skovhus
Copy link
Collaborator

skovhus commented Sep 24, 2018

Can you send us the file where this happened or a small reproducible snippet?

Please also include OS version and bash language server version.

Thanks.

@sandinmyjoints
Copy link

sandinmyjoints commented Oct 1, 2018

I am seeing this too.

  • bash-language-server@1.5.2
  • macOS 10.12.6

Seems to happen with any file, for example, if I create a file repro.bash containing:

ls

Happens when I hover over ls.

@sandinmyjoints
Copy link

Actually, I get a slightly different error message than the OP: Request textDocument/hover failed with message: undefined is not a valid argument for URI (Internal Error)

@skovhus
Copy link
Collaborator

skovhus commented Oct 1, 2018

@anishmittal2020 I'm wondering why it calls 127.0.0.1:5000. Did you set up bashIde.explainshellEndpoint as explained in the README?

@skovhus
Copy link
Collaborator

skovhus commented Oct 1, 2018

@sandinmyjoints

Actually, I get a slightly different error message than the OP: Request textDocument/hover failed with message: undefined is not a valid argument for URI (Internal Error)

Unfortunately I can't reproduce. Can you upload a screenshot of your entire editor and this error showing?

@skovhus skovhus added the question Further information is requested label Oct 1, 2018
@sandinmyjoints
Copy link

sandinmyjoints commented Oct 1, 2018

screenshot

This is Emacs 26.1 using https://github.com/emacs-lsp/lsp-sh

@mattiasb
Copy link

mattiasb commented Oct 4, 2018

I get the same error. My guess is that error is here. You should probably check for undefined as well.

@skovhus
Copy link
Collaborator

skovhus commented Oct 5, 2018

I get the same error. My guess is that error is here.

I think you are right. Good catch!

@mattiasb
Copy link

mattiasb commented Oct 5, 2018

I get the same error. My guess is that error is here.

I think you are right. Good catch!

I'm always right! humble brags 😂 😉

@skovhus
Copy link
Collaborator

skovhus commented Oct 5, 2018

Let me know if you want to create a PR. :)

@mattiasb
Copy link

mattiasb commented Oct 5, 2018

Let me know if you want to create a PR. :)

tbh I don't even know how to make an undefined-check in Typescript. It's not a language I have on my bucket-list so to speak. :P

skovhus added a commit that referenced this issue Oct 7, 2018
@skovhus
Copy link
Collaborator

skovhus commented Oct 7, 2018

Should be fixed in 1.5.4. Please try to upgrade by running a npm install -g bash-language-server

@skovhus skovhus closed this as completed Oct 7, 2018
@skovhus
Copy link
Collaborator

skovhus commented Oct 7, 2018

Let me know if it works for you guys. :) @anishmittal2020 @mattiasb

@mattiasb
Copy link

mattiasb commented Oct 7, 2018

Works like a charm, thanks! :)

domnewkirk added a commit to domnewkirk/bash-language-server that referenced this issue Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants