Add Jest integration tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome @skovhus. I'm all for adding this to the CI as well. I know it might be a no-brainer but could I get you to write a tiny section in the README about how to run the tests? |
|
I will. : ) |
|
@mads-hartmann let me know if the documentation looks good to you. I also added a travis configuration here. |
|
@skovhus Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the feedback loop of improving the language server and make contributions easier, I suggest that we add some Jest integration tests here.
It might have found an issue with the
wordAtPointfunction (see the FIXME).If we like this, I think next step would be to set up CI. I can look into that if you want. : )