Improve completion handler and wordAtPoint #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovhus
changed the title
Closed
akurtakov
added a commit
to akurtakov/shellwax
that referenced
this pull request
Mar 4, 2020
Changes in the LS: * Improved completion handler and support auto-completion and documentation for bash reserved words (bash-lsp/bash-language-server#192) * Upgrade tree-sitter Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
akurtakov
added a commit
to eclipse-shellwax/shellwax
that referenced
this pull request
Mar 4, 2020
Changes in the LS: * Improved completion handler and support auto-completion and documentation for bash reserved words (bash-lsp/bash-language-server#192) * Upgrade tree-sitter Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
skovhus
added a commit
that referenced
this pull request
May 19, 2020
The helper was originally introduced to make the detection of a word at a given point more accurate (this is used for completion, hovering, etc) and fixes some issues with the tree sitter grammar. It turns out this is really not needed and introduces a bunch of issues. Related to #192
skovhus
added a commit
that referenced
this pull request
May 19, 2020
The helper was originally introduced to make the detection of a word at a given point more accurate (this is used for completion, hovering, etc) and fixes some issues with the tree sitter grammar. It turns out this is really not needed and introduces a bunch of issues. Related to #192
domnewkirk
added a commit
to domnewkirk/bash-language-server
that referenced
this pull request
Jul 20, 2024
The helper was originally introduced to make the detection of a word at a given point more accurate (this is used for completion, hovering, etc) and fixes some issues with the tree sitter grammar. It turns out this is really not needed and introduces a bunch of issues. Related to bash-lsp/bash-language-server#192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #83
This is an iteration on the great work by @thomasjm (see context in #119). It improves several aspects of the server:
case,do,if,while)Before (left) and after (right)
I've done a bunch of manual testing, and tried to document the results here:
Removed weird autocomplete on
set -x(due to improved word handling):Autocompletion when a word is already written (note that we have duplications here with builtins and man pages):
Bash reserved words are now supported (e.g. if, else)
This also solved the
case/esacissue reported in #83