Throttle ShellCheck requests to limit CPU usage #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on vscode ThrottledDelayer
skovhus
force-pushed
the
debounce-shellcheck
branch
from
10e96a8
to
f6ef9ea
Compare
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #654
Reduce CPU usage by introduce a short execution delay and throttling for ShellCheck tasks. This is similar to how the vscode shellcheck extension works.
On OS X I can't reproduce a massive CPU usage before this change, but after adding the throttling the CPU time drops from 1,5 to 0.18.
Maybe related to: #594 #638 #630