-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latency stats items to S3 API and velvet calls [JIRA: RCS-220] #1180
Conversation
With small callback function for each WM callback sub-modules
- Change command to switch stanchion to riak-cs-admin, avoiding depricated warning - Fix stats item number - Fix stats item name for back pressure sleep
Fixed riak_test failures, became ready for review actually. |
Action = case Operation of | ||
create -> created; | ||
delete -> deleted; | ||
_ -> undefined | ||
end, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation looks strange to me, which should be aligned with case
.
Thanks for pointing out. Fixed as to two comments above and pushed. |
ok = riak_cs_stats:update_with_start(StatName, | ||
StartTime), | ||
X | ||
riak_cs_user:save_user(UpdUser, UserObj, RcPid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So are we supposed to measure this call in next pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Stats in riakc calls are NOT included. Will be in next.
@@ -157,6 +162,7 @@ delete_resource(RD, Ctx=#context{user=User, | |||
ok -> | |||
riak_cs_dtrace:dt_bucket_return(?MODULE, <<"bucket_delete">>, | |||
[200], [riak_cs_wm_utils:extract_name(User), Bucket]), | |||
ok = riak_cs_stats:update_with_start([bucket, delete], StartTime), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have update_with_start/3
here? Isn't this caught at riak_cs_wm_common:update_stats
?
How about adding items in |
Thanks for review. Pushed the fix for your comments. Please let me defer modification of |
|
Add latency stats items to S3 API and velvet calls [JIRA: RCS-220] Reviewed-by: kuenishi
nooooooooooooooooooo |
The fail was about eunit. All tests have succeeded but failed after that.
|
@borshop: retry |
Add latency stats items to S3 API and velvet calls [JIRA: RCS-220] Reviewed-by: kuenishi
@borshop merge |
TODO: write down release note _[posted via JIRA by Kota Uenishi]_ |
This is a part of RCS-11 work; release notes will be written there. _[posted via JIRA by Kota Uenishi]_ |
Part 2 of stats improvement following #1165 (RCS-204) and address #961 (RCS-37) (RCS-217) partially.
This PR adds: