Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supercluster by cuttlefish schema (aka multibag name chage) #1257

Merged
merged 2 commits into from
Oct 6, 2015

Conversation

shino
Copy link
Contributor

@shino shino commented Oct 6, 2015

@shino shino added this to the 2.1.0 milestone Oct 6, 2015
@shino
Copy link
Contributor Author

shino commented Oct 6, 2015

For testing make package, I pushed temporary tag 2.1.0 to riak_cs_multibag repository at the HEAD of PR basho/riak_cs_multibag#31. It must be removed after all PRs are merged and 2.1.0 tag must be pushed for the merged commit.

%% value is a PB address of Riak node to connect.
{mapping, "supercluster.member.$member_id", "riak_cs_multibag.bags", [
{datatype, ip},
{include_default, "bag-A"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best way is to match the string here with one in the doc (in the future.) This is not user-facing because of hidden, how about leaving as it is and defer change ?

@kuenishi
Copy link
Contributor

kuenishi commented Oct 6, 2015

With unreachable IP address lines like supercluster.member.alpha = 127.0.99.99:8087 included in riak-cs.conf, riak-cs console hangs before starting to listen port, then we can't hit any S3 API. The message is as follows:

opening log file: "./log/access.log.2015_10_06_07"
Setup running ...
Directories verified. Res = {[ok],[]}
Setup finished processing hooks ...
(and hangs)

The setup 1.4 code seems broken there;

   case application:get_env(stop_when_done) of
        {ok, true} ->
            io:fwrite("Setup stopping...~n", []),
            timer:sleep(timer:seconds(5)),
            rpc:eval_everywhere(init,stop,[0]);
        _ ->
            timer:sleep(infinity)
    end.

This is fixed in latest exometer_core 1.4 that is using setup 1.5.

@kuenishi
Copy link
Contributor

kuenishi commented Oct 6, 2015

But this is not a issue of this pull request. Going to 👍

borshop added a commit that referenced this pull request Oct 6, 2015
Supercluster by cuttlefish schema (aka multibag name chage)

Reviewed-by: kuenishi
@shino
Copy link
Contributor Author

shino commented Oct 6, 2015

@borshop merge

@borshop borshop merged commit f265d3e into 2.1 Oct 6, 2015
@shino shino deleted the feature/supercluster-by-cf branch October 6, 2015 08:39
@shino
Copy link
Contributor Author

shino commented Oct 6, 2015

For release note: supercluster (aka multibag) configuration can be done in riak-cs.conf and stanchion.conf.

For members of supercluster, riak-cs.conf and stanchion.conf:

supercluster.member.sc-member-A=127.0.0.1:10017
supercluster.member.sc-member-B=127.0.0.1:10027
supercluster.member.sc-member-C=127.0.0.1:10037
supercluster.member.sc-member-D=127.0.0.1:10047

and refresh interval for riak-cs.conf

supercluster.weight_refresh_interval = 15m

Also, riak-cs-multibag command is renamed to riak-cs-supercluster (old one still remains but deprecated) and its subcommand list-bags is changed to list-members.

@shino
Copy link
Contributor Author

shino commented Oct 7, 2015

Addition from [1] and [2].

Settings for riak-cs.conf and stanchion.conf is not changed.
advanced.config for riak_cs and stanchion can have supercluster members settings as

{riak_cs,
 [{supercluster_memebers,
   [{"Laniakea", "192.168.0.101", 8087},
    {"Virgo",  "192.168.0.102", 8087},
    ...
    ]}]
    }

(for stanchion, change riak_cs to stanchion).

For backward compatibility, advanced.config or app.config for riak_cs can be

{riak_cs_multibag,
 [{bags,
   [{"Laniakea", "192.168.0.101", 8087},
    {"Virgo",  "192.168.0.102", 8087},
    ...
    ]}]
    }

or

{stanchion,
 [{bags,
   [{"Laniakea", "192.168.0.101", 8087},
    {"Virgo",  "192.168.0.102", 8087},
    ...
    ]}]
    }

Somewhat complicated because of back tax.

[1] #1260
[2] basho/stanchion#107

This was referenced Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants