Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for amendment log, and a bit code reformat #988

Merged
merged 8 commits into from
Oct 9, 2014

Conversation

kuenishi
Copy link
Contributor

@kuenishi kuenishi commented Oct 9, 2014

RIAK-1212

  • Add a function riak_cs_access:flush_to_log/2,3 which outputs one access key and value supposed to be put into moss.access.
  • flush_to_log/2 folds around all ets entries and outputs all of them to each line, with JSON encoded
  • flush_to_log/3 outputs single key and value to log.
  • The test works as follows:
    • write some data to CS
    • kill all Riak process
    • try to flush the access stats
    • check Riak CS log and verifies whether correct log is updated or not.

@shino
Copy link
Contributor

shino commented Oct 9, 2014

I want some description about the change. One with just one or two lines is fine.

@kuenishi
Copy link
Contributor Author

kuenishi commented Oct 9, 2014

  • Add a function riak_cs_access:flush_to_log/2,3 which outputs one access key and value supposed to be put into moss.access.
  • flush_to_log/2 folds around all ets entries and outputs all of them to each line, with JSON encoded
  • flush_to_log/3 outputs single key and value to log.
  • The test works as follows:
    • write some data to CS
    • kill all Riak process
    • try to flush the access stats
    • check Riak CS log and verifies whether correct log is updated or not.
  • And some code reformatting added.

@shino
Copy link
Contributor

shino commented Oct 9, 2014

Copied the above comment to the PR description.

@kuenishi kuenishi force-pushed the feature/logging-access-stats-2 branch from de9bd7c to f7b6024 Compare October 9, 2014 07:47
@kuenishi kuenishi mentioned this pull request Oct 9, 2014
@shino shino modified the milestone: 1.5.2 Oct 9, 2014
@ksauzz
Copy link
Contributor

ksauzz commented Oct 9, 2014

borshop added a commit that referenced this pull request Oct 9, 2014
Add tests for amendment log, and a bit code reformat

Reviewed-by: ksauzz
@kuenishi
Copy link
Contributor Author

kuenishi commented Oct 9, 2014

@borshop merge

@borshop borshop merged commit 01d44db into release/1.5 Oct 9, 2014
@kuenishi kuenishi deleted the feature/logging-access-stats-2 branch October 9, 2014 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants