Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile #12

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Dockerfile #12

merged 2 commits into from
Feb 8, 2020

Conversation

lukasmrtvy
Copy link
Contributor

Interested in this simple Dockerfile ?
Would be also great to setup official docker hub repository ( https://docs.docker.com/docker-hub/builds/ ).

@fbartels
Copy link
Contributor

You could make the resulting image even smaller by using https://github.com/halverneus/static-file-server as the base image.

@fhemberger
Copy link

@fbartels Dockerfile would be nice and short this way:

FROM halverneus/static-file-server
COPY . /web

Web server is exposed by default on port 8080.

@bastienwirtz
Copy link
Owner

Hi,
Thanks all of you! I'll look into it & test it asap.
@fbartels @fhemberger the static file server image looks nice but the initial proposition is still quite small and clean, and as it come straight from the official base alpine image, it removes a level of dependency, it's a solid choice for maintainability.

fhemberger
fhemberger reviewed Jan 29, 2020
View reviewed changes
Dockerfile Outdated

COPY ./ /www/

ENV USER abc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you please rename the user/group to darkhttpd?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 That would be great!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lukasmrtvy
Copy link
Contributor Author

I can add s6 overlay for runtime uid,gid change , if You want to implement some crud to local config in the future to support proper volume handling..

@bastienwirtz
Copy link
Owner

Finally got to test it, looks good 👍
Thanks!

@bastienwirtz bastienwirtz merged commit 672bd42 into bastienwirtz:master Feb 8, 2020
@calvinbui
Copy link
Contributor

@bastienwirtz could you enable the Docker Hub builds?

@calvinbui calvinbui mentioned this pull request Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhemberger fhemberger fhemberger left review comments

@bastienwirtz bastienwirtz bastienwirtz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukasmrtvy @fbartels @fhemberger @bastienwirtz @calvinbui