Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #121 - Change default theme and layout from config #311

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

Aryess
Copy link
Contributor

@Aryess Aryess commented Oct 12, 2021

Description

This PR adds default values in the config for the theme (dark/light/auto), and the layout (column/list). Respects the current default, if no config is changed, default will still be auto/column.

Fixes #121

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@robinschneider
Copy link
Contributor

I think it would be better to set the current values in code as default if they are not provided by the config file, so if anyone updates there homer and does not habe these set it will still work.

@Aryess
Copy link
Contributor Author

Aryess commented Oct 13, 2021

Maybe I misunderstood you comment, but given the values are set in src/assets/defaults.yml, so even when updating existing installs, it shouldn't be an issue?

Happy to test this further if you want though

@Aryess
Copy link
Contributor Author

Aryess commented Oct 28, 2021

@bastienwirtz sorry to be pushy but could you please have a look at this?

@Logicer16
Copy link

@bastienwirtz could you please take a minute to look at this. It would be a useful feature to have.

@Roundaround Roundaround merged commit 049610b into bastienwirtz:main Mar 13, 2022
@Roundaround
Copy link
Contributor

Looks good to me, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Change default theme and layout from config
4 participants