Add docker build-arg to disable PWA / serviceworker (Fixes #232) #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a build argument to disable the registration of the service worker. Therefore, homer is no longer installed as a progressive web app (PWA) when the build argument was provided during build. That fixes problems when using homer behind an authenticating proxy such as Authalia or oauth2-proxy.
The build argument can be added to the Docker build using
docker build --build-arg VUE_APP_DISABLE_PWA=true .
.When the build argument is not provided, Homer is build like normal, inlcuding the PWA.
I propose releasesing two versions of the Docker image: one with PWA & one without PWA. Example: latest & latest-no-pwa.
Fixes #232
Type of change
Checklist:
config.yml
file