Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init octoprint service #324

Merged
merged 38 commits into from
Nov 26, 2022
Merged

Conversation

FriendlyNGeeks
Copy link

@FriendlyNGeeks FriendlyNGeeks commented Oct 31, 2021

status | progress | time elapsed | time left
using config.yml as such :

  • name: "OctoPrint"
    type: "OctoPrint"
    subtitle: "OctoPrint"
    apikey: "your application api key here"
    logo: "assets/tools/sample.png"
    url: "http://octopi.local" # may require Allow Cross Origin Resource Sharing (CORS) if not using ip4 address
    target: "_blank"
    octopi-homer

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I've read & comply with the contributing guidelines

  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

  • I have made corresponding changes to the documentation (README.md).

  • I've checked my modifications for any breaking changes, especially in the config.yml file

status | progress | time elapsed | time left 
using api key in config.yml
@FriendlyNGeeks FriendlyNGeeks changed the title init init octoprint service Nov 1, 2021
returns added to if conditions and subtitle returns if octopi api fails
Copy link
Author

@FriendlyNGeeks FriendlyNGeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ifs with returns ran vue lint - PASSED

docker-compose.yml Outdated Show resolved Hide resolved
src/components/services/OctoPi.vue Outdated Show resolved Hide resolved
src/components/services/OctoPi.vue Outdated Show resolved Hide resolved
src/components/services/OctoPi.vue Outdated Show resolved Hide resolved
src/components/services/OctoPi.vue Outdated Show resolved Hide resolved
Copy link
Author

@FriendlyNGeeks FriendlyNGeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now with let and const and reverse if and service rename

Copy link
Author

@FriendlyNGeeks FriendlyNGeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed vue if statement into one continuous

@FriendlyNGeeks
Copy link
Author

@Roundaround can you assist me with this review

@bastienwirtz
Copy link
Owner

Of course @FriendlyNGeeks and sorry for the delay.

First, thank you for working on octoprint, it's gonna be a great addition to the available custom services.
The main issue now is that since you opened it, the code base changed and this PR need a rebase / cleanup (if you look at the diff, multiple changes don't belong here), and a few minor code change.

If you're ok with it, I can merge it in a new branch, and do the cleanup myself.
Would it be ok for you ?

@FriendlyNGeeks
Copy link
Author

Yes please just merge and cleanup, I dont care how you get it in there. Its been a learning process for me as well. I do apologize for my messy code which delayed this.

@bastienwirtz
Copy link
Owner

No worries, I'm glad it helped you learned and sorry I didn't helped you sooner.

If you could send me some examples of API output it would help me a lot. Just save the Json the API gives you in a static file, maybe in different situations (no printing, in progress, done). You can add it anywhere in this pr, I will remove it later.

Thanks.

@FriendlyNGeeks
Copy link
Author

@bastienwirtz | completion time shows 100.0 | error is an example if you lose power to printer
octoprint_status_jsons.zip

@FriendlyNGeeks
Copy link
Author

@bastienwirtz do you need anything else from me for the merge?

@bastienwirtz
Copy link
Owner

@FriendlyNGeeks It's perfect thanks ! I'll find some time to work on it soon. I'll keep you posted.

@bastienwirtz bastienwirtz changed the base branch from main to octoprint-rework November 26, 2022 10:35
@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit c51e57a
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/6381eca38e59fe0008801861
😎 Deploy Preview https://deploy-preview-324--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bastienwirtz bastienwirtz merged commit f6f85ee into bastienwirtz:octoprint-rework Nov 26, 2022
bastienwirtz pushed a commit that referenced this pull request Nov 27, 2022
Add Octoprint service
@bastienwirtz bastienwirtz mentioned this pull request Nov 27, 2022
7 tasks
bastienwirtz added a commit that referenced this pull request Nov 27, 2022
Add Octoprint service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants