-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init octoprint service #324
init octoprint service #324
Conversation
returns added to if conditions and subtitle returns if octopi api fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated ifs with returns ran vue lint - PASSED
Co-authored-by: Evan Steinkerchner <esteinkerchner@gmail.com>
Co-authored-by: Evan Steinkerchner <esteinkerchner@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine now with let and const and reverse if and service rename
Combined template vue if statement line 9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed vue if statement into one continuous
@Roundaround can you assist me with this review |
Of course @FriendlyNGeeks and sorry for the delay. First, thank you for working on octoprint, it's gonna be a great addition to the available custom services. If you're ok with it, I can merge it in a new branch, and do the cleanup myself. |
Yes please just merge and cleanup, I dont care how you get it in there. Its been a learning process for me as well. I do apologize for my messy code which delayed this. |
No worries, I'm glad it helped you learned and sorry I didn't helped you sooner. If you could send me some examples of API output it would help me a lot. Just save the Json the API gives you in a static file, maybe in different situations (no printing, in progress, done). You can add it anywhere in this pr, I will remove it later. Thanks. |
@bastienwirtz | completion time shows 100.0 | error is an example if you lose power to printer |
@bastienwirtz do you need anything else from me for the merge? |
@FriendlyNGeeks It's perfect thanks ! I'll find some time to work on it soon. I'll keep you posted. |
✅ Deploy Preview for homer-demo-content ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
status | progress | time elapsed | time left
using config.yml as such :
type: "OctoPrint"
subtitle: "OctoPrint"
apikey: "your application api key here"
logo: "assets/tools/sample.png"
url: "http://octopi.local" # may require Allow Cross Origin Resource Sharing (CORS) if not using ip4 address
target: "_blank"
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Checklist:
I've read & comply with the contributing guidelines
I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
I have made corresponding changes to the documentation (README.md).
I've checked my modifications for any breaking changes, especially in the
config.yml
file