feat: allow http-parser NODE_OPTION in packaged apps (electron#21694)

bavulapati · Jan 9, 2020 · bb05471 · bb05471
1 parent 75e39be
commit bb05471
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/docs/api/environment-variables.md b/docs/api/environment-variables.md
@@ -48,6 +48,7 @@ Unsupported options are:
 
 ```sh
 --max-http-header-size
+--http-parser
 ```
 
 ### `GOOGLE_API_KEY`

diff --git a/shell/common/node_bindings.cc b/shell/common/node_bindings.cc
@@ -144,7 +144,8 @@ void SetNodeOptions(base::Environment* env) {
       "--force-fips", "--enable-fips"};
 
   // Subset of options allowed in packaged apps
-  const std::set<std::string> allowed_in_packaged = {"--max-http-header-size"};
+  const std::set<std::string> allowed_in_packaged = {"--max-http-header-size",
+                                                     "--http-parser"};
 
   if (env->HasVar("NODE_OPTIONS")) {
     std::string options;