go_repository: avoid unnecessary fetches in HTTP mode #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jfirebaugh
added a commit
to figma/bazel-gazelle
that referenced
this pull request
Mar 13, 2023
See bazel-contrib#1175 and bazel-contrib#1206. The pull request was conservative and only fixed restarts for repositories where it could be statically determined that `@bazel_gazelle_go_repository_tools//:bin/gazelle` was needed. It did not avoid restarts in the case where `go_repository` needs to fetch and examine the repo to determine if it requires `@bazel_gazelle_go_repository_tools`. But that's the common case for `go_repository`, so this patches the implementation to unconditionally require `@bazel_gazelle_go_repository_tools`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
go_repositoryrule is in HTTP mode and hasbuild_file_generation = onit can result in unnecessary calls todownload_and_extractwhile the@bazel_gazelle_go_repository_toolsand@bazel_gazelle_go_repository_cachelabels are still not available. Note that redundant fetches can be unavoidable when in HTTP mode andbuild_file_generation = autobecause the rule needs to fetch and examine the repo to determine if it requires@bazel_gazelle_go_repository_tools.For more info about repository rule restarting see:
https://docs.bazel.build/versions/5.0.0/skylark/repository_rules.html#when-is-the-implementation-function-executed
Resolve #1175