Skip to content

Commit

Permalink
Fix for #1271, set_file_prefix_map attribute (#1288)
Browse files Browse the repository at this point in the history
  • Loading branch information
aaron-michaux authored Sep 19, 2024
1 parent b25485b commit e67c45c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
5 changes: 5 additions & 0 deletions foreign_cc/private/cc_toolchain_util.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ def get_flags_info(ctx, link_output_file = None):
),
),
)

if "set_file_prefix_map" in dir(ctx.attr) and ctx.attr.set_file_prefix_map:
copts.append("-ffile-prefix-map=$EXT_BUILD_ROOT=.")
cxxopts.append("-ffile-prefix-map=$EXT_BUILD_ROOT=.")

return CxxFlagsInfo(
cc = _convert_flags(cc_toolchain_.compiler, _add_if_needed(flags.cc, copts)),
cxx = _convert_flags(cc_toolchain_.compiler, _add_if_needed(flags.cxx, cxxopts)),
Expand Down
8 changes: 8 additions & 0 deletions foreign_cc/private/framework.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,14 @@ CC_EXTERNAL_RULE_ATTRIBUTES = {
doc = "Optional part of the shell script to be added after the make commands",
mandatory = False,
),
"set_file_prefix_map": attr.bool(
doc = (
"Use -ffile-prefix-map with the intention to remove the sandbox path from " +
"debug symbols"
),
mandatory = False,
default = False,
),
"targets": attr.string_list(
doc = (
"A list of targets with in the foreign build system to produce. An empty string (`\"\"`) will result in " +
Expand Down

0 comments on commit e67c45c

Please sign in to comment.