Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup_args and run meson setup explictly #1223

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

allsey87
Copy link
Contributor

@allsey87 allsey87 commented Jul 8, 2024

Resolves #1170

@allsey87
Copy link
Contributor Author

allsey87 commented Jul 8, 2024

The failed test seems to be caused by issues with the CI rather than this PR. It's a bit of a mixed bag, so I have copied what seems to be the main error for each failing job.

Buildifier

2024-07-08 11:06:49 INFO   Reading annotation body from STDIN
🚨 Error: The command exited with status 4
user command error: The plugin docker command hook exited with status 4

Examples (spawn_strategy=standalone)

stderr: ld: unknown options: --version
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error in child process '/usr/bin/xcrun'. 1

Examples on MacOS

WARNING: ignoring JAVA_TOOL_OPTIONS in environment.
... still trying to connect to local Bazel server (9378) after 10 seconds ...
... still trying to connect to local Bazel server (9378) after 20 seconds ...
... still trying to connect to local Bazel server (9378) after 30 seconds ...
... still trying to connect to local Bazel server (9378) after 40 seconds ...
... still trying to connect to local Bazel server (9378) after 50 seconds ...
... still trying to connect to local Bazel server (9378) after 60 seconds ...
... still trying to connect to local Bazel server (9378) after 70 seconds ...
... still trying to connect to local Bazel server (9378) after 80 seconds ...
... still trying to connect to local Bazel server (9378) after 90 seconds ...
... still trying to connect to local Bazel server (9378) after 100 seconds ...
... still trying to connect to local Bazel server (9378) after 110 seconds ...
FATAL: couldn't connect to server (9378) after 120 seconds.

Flags on MacOS

Jul 08 13:07:12.114 ERROR bazelci_agent::artifact::upload: Failed to read /tmp/tmp0xfeep4y/test_bep.json
Caused by:
    No such file or directory (os error 2)

@jsharpe
Copy link
Member

jsharpe commented Jul 9, 2024

The buildifier failure is an issue in this PR:
image

The macOS failures do seem to correlate with the switch to use VMs in bazel's CI; I suspect they've either bumped macOS version or are missing some preinstalled tooling that we depend on as main is also failing.

@jsharpe
Copy link
Member

jsharpe commented Jul 9, 2024

@jheaff1 do you have time to review the changes in this PR?

Place dictionary items in lexicographical order
@allsey87
Copy link
Contributor Author

allsey87 commented Jul 9, 2024

The buildifier failure is an issue in this PR

Fixed in c7bcf7d

@jsharpe
Copy link
Member

jsharpe commented Jul 9, 2024

Looks like the other macOS failures are due to the runners upgrading the version of XCode installed.. The fix for this likely needs to come in the apple toolchain.

@allsey87
Copy link
Contributor Author

I think this is ready for review?

Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without really knowing meson, this seems a reasonable change and CI is now all green so I'm happy with this.

@jsharpe jsharpe enabled auto-merge (squash) August 8, 2024 10:04
@jsharpe jsharpe merged commit af66969 into bazel-contrib:main Aug 8, 2024
2 checks passed
jsharpe added a commit to jsharpe/rules_foreign_cc that referenced this pull request Aug 23, 2024
Co-authored-by: James Sharpe <james.sharpe@zenotech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a setup_args argument to the meson rule
2 participants