Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencie with bazelbuild/rules_cc #2950

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Sep 9, 2021

Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc.
However rules_cc was always saying that there is no need to use them yet.
After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it.
One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit:
bazelbuild/rules_cc#91
bazelbuild/rules_cc#68

The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc.

More information about the discussions:
bazelbuild/rules_cc#86
bazelbuild/rules_cc#92
bazelbuild/buildtools#923
bazelbuild/buildtools#952

Fixes #2949

@google-cla google-cla bot added the cla: yes label Sep 9, 2021
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc.
However rules_cc was always saying that there is no need to use them yet.
After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it.
One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit:
bazelbuild/rules_cc#91
bazelbuild/rules_cc#68

The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc.

More information about the discussions:
bazelbuild/rules_cc#86
bazelbuild/rules_cc#92
bazelbuild/buildtools#923
bazelbuild/buildtools#952

Fixes bazel-contrib#2949
@achew22
Copy link
Member

achew22 commented Sep 10, 2021

Based on @oquenchil 's comments in bazelbuild/rules_cc#91 (comment):

[...] we deem rules_cc a mistake and we shouldn't have created it before finishing starlarkifying the rules.

it seems that rules_cc is not worth the hassle and isn't going to be the thing going forward. I'm going to merge this, removing the dependency on rules_cc and when/if that becomes the correct tool to use we can either revert this, or change the repo to adapt.

@achew22 achew22 merged commit 5efc3c2 into bazel-contrib:master Sep 10, 2021
rHermes added a commit to rHermes/benchmark that referenced this pull request Nov 14, 2021
It seems according to [1] that bazelbuild/rules_cc has been put on hold
and that the recommended way for now, is to use the native cc rules.

[1]: bazel-contrib/rules_go#2950
dmah42 pushed a commit to google/benchmark that referenced this pull request Nov 14, 2021
It seems according to [1] that bazelbuild/rules_cc has been put on hold
and that the recommended way for now, is to use the native cc rules.

[1]: bazel-contrib/rules_go#2950
sergiud pushed a commit to sergiud/benchmark that referenced this pull request Jan 13, 2022
It seems according to [1] that bazelbuild/rules_cc has been put on hold
and that the recommended way for now, is to use the native cc rules.

[1]: bazel-contrib/rules_go#2950
dneto0 added a commit to dneto0/effcee that referenced this pull request Dec 21, 2022
Stop using an external rules_cc dependency. Use internal C/C++ rules
instead.
- Follows googletest in doing this.
  google/googletest#3574
- See also: bazel-contrib/rules_go#2950
This appears necessary for compatibility with Bazel 5.0.0 and Bazel 6.0.0

Update to googletest-release-1.12.1, the last release that only needs a
C++11 compiler, and doesn't require C++14.

Update to re2-2022-12-01

I have successfully built and tested effcee with this configuration
on Linux x86-64 with Bazel 5.0.0 and Bazel 6.0.0.
dneto0 added a commit to google/effcee that referenced this pull request Dec 21, 2022
Stop using an external rules_cc dependency. Use internal C/C++ rules
instead.
- Follows googletest in doing this.
  google/googletest#3574
- See also: bazel-contrib/rules_go#2950
This appears necessary for compatibility with Bazel 5.0.0 and Bazel 6.0.0

Update to googletest-release-1.12.1, the last release that only needs a
C++11 compiler, and doesn't require C++14.

Update to re2-2022-12-01

I have successfully built and tested effcee with this configuration
on Linux x86-64 with Bazel 5.0.0 and Bazel 6.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencie with bazelbuild/rules_cc
2 participants