Remove get_nogo from context #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Aug 11, 2024
tyler-french
pushed a commit
that referenced
this pull request
Aug 30, 2024
**What type of PR is this?** Cleanup **What does this PR do? Why is it needed?** It seems odd to hang helpers off the `go` context because they still need to take `go` as a param. It's clearer to just import them. **Which issues(s) does this PR fix?** Fixes # **Other notes for review**
tyler-french
pushed a commit
that referenced
this pull request
Aug 30, 2024
**What type of PR is this?** Cleanup **What does this PR do? Why is it needed?** It seems odd to hang helpers off the `go` context because they still need to take `go` as a param. It's clearer to just import them. **Which issues(s) does this PR fix?** Fixes # **Other notes for review**
tyler-french
pushed a commit
to tyler-french/rules_go
that referenced
this pull request
Sep 4, 2024
**What type of PR is this?** Cleanup **What does this PR do? Why is it needed?** It seems odd to hang helpers off the `go` context because they still need to take `go` as a param. It's clearer to just import them. **Which issues(s) does this PR fix?** Fixes # **Other notes for review**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
It seems odd to hang helpers off the
gocontext because they still need to takegoas a param. It's clearer to just import them.Which issues(s) does this PR fix?
Fixes #
Other notes for review