-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gomock: allow passing extra flags to mockgen_tool #4066
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
e9c259f
to
2311def
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach more, adding attributes for single args doesn't scale.
Could you also revert 4feb7b8 in this PR?
This reverts commit 4feb7b8. Not needed anymore if we add generic `mockgen_args`
Sure, done! |
What type of PR is this?
What does this PR do? Why is it needed?
Adds the ability to pass extra arguments to gomock
Which issues(s) does this PR fix?
Fixes #4065
Closes #4067
Other notes for review
#4067 is another way to do it, but I think accepting an argument list is cleaner