BUGFIX: Adds the static libraries from cgo_deps to the link command line #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case that exercises this logic and fails without it? cgo is complicated enough that I wouldn't want to make a change without a test. |
Not sure why this wasn't added here.
|
Sorry, this is not a polished fix. This just illustrates what seems to be a glaring omission in how cgo binaries are linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this wasn't added here.
What type of PR is this?
Bug fix repro.
At least I think.
What does this PR do? Why is it needed?
It adds the
.alibraries when linking a go program with C or C++ FFI archive.I am not seeing why this is not being done when linking the binary.
An alternative is to add
linkmode = "c-shared", orlinkmode = "c-archive", but this is not correct if you want an actual executable, and not a library.Which issues(s) does this PR fix?
Fixes #
Other notes for review