Load JavaInfo and java_common from rules_java #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comius
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
comius
force-pushed
the
load_java_modules
branch
2 times, most recently
from
242ccf4
to
1243532
Compare
comius
force-pushed
the
load_java_modules
branch
from
1243532
to
c3c6812
Compare
shs96c
requested changes
Oct 11, 2023
| @@ -4,17 +4,16 @@ module( | |||
| ) | |||
|
|
|||
| bazel_dep(name = "bazel_skylib", version = "1.4.2") | |||
| bazel_dep(name = "stardoc", repo_name = "io_bazel_stardoc", version = "0.5.3") | |||
| bazel_dep(name = "stardoc", version = "0.5.3", repo_name = "io_bazel_stardoc") | |||
There was a problem hiding this comment.
This should be a dev dependency because we don't expect people to depend on targets in the top-level build file.
| @@ -21,26 +21,6 @@ tasks: | |||
| # These tests are currently incompatible with RBE | |||
| - "-//tests/integration/override_targets" | |||
| - "-//tests/com/github/bazelbuild/rules_jvm_external/maven:OutdatedTest" | |||
| ubuntu1804_4_0_0: | |||
| platform: ubuntu1804 | |||
| bazel: 4.0.0 | |||
There was a problem hiding this comment.
Dropping support for Bazel 4 is on the roadmap, but I'm curious about why this change is made in this PR
shs96c
added a commit
to shs96c/rules_jvm_external
that referenced
this pull request
Jan 5, 2024
This prepares rules_jvm_external for bazelbuild/bazel#19455 Closes bazel-contrib#967 which has been left in limbo.
|
Closing as this is replaced by #1027 |
shs96c
added a commit
that referenced
this pull request
Jan 15, 2024
This prepares rules_jvm_external for bazelbuild/bazel#19455 Closes #967 which has been left in limbo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares rules_jvm_external for bazelbuild/bazel#19455