feat(builtin): add configuration_env_vars to npm_package_bin #1549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaves similarly to
configuration_env_vars
innodejs_binary
except it passes the env vars to the process via theenv
attribute ofctx.actions.run
.Also add support for picking up env vars from
ctx.configuration.default_shell_env
if they are not found inctx.vars
.ctx.vars
will contain values from--define=FOO=BAR
ctx.configuration.default_shell_env
will--action_env=FOO=BAR
(but not from--action_env=FOO
).test: add test coverage for npm_package_bin configuration_env_vars
And test coverage for using --action_env=FOO=BAR to pass env variables to npm_package_bin & nodejs_binary