-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bzlmod): add trivial pass-through module extension for oci_pull #118
Conversation
I made an example to test this, and there's a bug. Problem here is
which is caused by https://github.com/bazel-contrib/rules_oci/blob/main/oci/pull.bzl#L246 I wanted to have nice syntax sugar for users to choose a base image like just |
I'm missing some pieces here. So you want to be able to pass in |
|
5bff7ef
to
de2d668
Compare
However it trips over the labels in our generated build files making assumptions about repository names, needs some fixing
de2d668
to
9357fde
Compare
This avoids it being affected by bzlmod repository mapping
9357fde
to
9f537b7
Compare
it doesn't support docker-format images. Most users want crane to be the registry instead.
okay the downstream example is green now! |
However it trips over the labels in our generated build files making assumptions about repository names, needs some fixing