Hermetic Core Utilities #409
Conversation
We use `xargs` which is not part of `coreutils`.
The part that uses `xargs` could be rewritten with something similar to:
```sh
while IFS= read -r LINE; do
# Do something with `$LINE`
# _or_ use `IFS` splitting to process the tag file
done < "${TAG_FILE}"
```
|
Related to #385 in terms of hermetic-ness of the project. |
|
Hey, thank you for the PR. I would love to land this, but currently there's a problem with the coreutils toolchain on darwin/arm64 where if rosetta is disabled, it fails horribly. |
|
cross-ref: uutils/coreutils#4104 |
|
This is now unblocked, we will accept the PR once we upgrade bazel-lib here. |
|
Along with Bazel 7 release we'll drop Bazel 5 support, that will be our chance to make a 2.0 release here, which in turn lets us make the breaking change of requiring bazel-lib 2.0. Sorry this got tied up in our semver ... |
|
No worries. We use if [[ -e "${TAGS_FILE:-}" ]]; then
cat "${TAGS_FILE}" | xargs -n1 "${CRANE}" tag $(cat "${REFS}")
fiThe docs say:
if [[ -e "${TAGS_FILE:-}" ]]; then
for IFS= read -r TAG; do
"${CRANE}" tag $(cat "${REFS}")
done <"${TAGS_FILE}"
fiWhich would get rid of another external program. I can put up a separate PR or add it to this one, if that is something we'd be happy to take. |
|
@mattyclarkson do you mind rebasing this PR against 2.x, and we'll land it there? |
|
Okay closing this as it's not landable as is. Feel free to create a new PR rebased on top 2.x. |
This expands it usage in the shell script for other core utilities in more of the shell scripts.
The usage of
xargscould be rewritten in pure Bash, maybe.Hoping to get
rules_ocito a point where it require zero tooling from the host 🤞