Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't include xattr #579

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: don't include xattr #579

merged 1 commit into from
May 20, 2024

Conversation

alexeagle
Copy link
Collaborator

Partial back-port of #385 from the 2.x branch

@alexeagle alexeagle requested a review from thesayyn May 16, 2024 19:20
@alexeagle
fix(oci_tarball): add --no-attr
a902475 
Partial back-port of #385 from the 2.x branch
thesayyn
thesayyn approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully bsdtar and gnutar both have these options.

@alexeagle alexeagle changed the title fix: don't include mac metadata fix: don't include xattr May 16, 2024
@alexeagle
Copy link
Collaborator Author

GNU tar doesn't have --no-mac-metadata so I removed from this PR. waiting on Sean to find out if that's enough to solve the problem.

@alexeagle
Copy link
Collaborator Author

This is strictly improvement so I'm going to merge even if it doesn't resolve an issue.

@alexeagle alexeagle merged commit 49fbc76 into main May 20, 2024
20 checks passed
@alexeagle alexeagle deleted the mac-metadata branch May 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @thesayyn