fix: propagate transitive inputs #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
fix_transitive_inputs
branch
from
786ad0e
to
0a2cbe9
Compare
alexeagle
reviewed
Jul 3, 2024
alexeagle
approved these changes
Jul 3, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has surfaced as bug in most of the places like #643, #642 (most likely).
The problem was that when symlinks were enabled on Bazel 7, the logic did not propagate the file dependencies correctly downstream which lead to some obscure errors i have mentioned above.
Now that we have some provider hierarchy, it makes me think if we should have a provider here, as requested in: #279