Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to oci_image #76

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

psalaberria002
Copy link
Contributor

@psalaberria002 psalaberria002 commented Feb 24, 2023

Fixes #47

I would like to have stamping support before merging this PR. I see @alexeagle is working on stamping in #70.

From what I understand, the script that builds the image will need to read the volatile and stable files when stamping is enabled, and do variable substitution for each key (if found). Should I try something like https://github.com/aspect-build/bazel-lib/blob/998ee223690ed07b3dfc31738dae839206bd60b0/lib/tests/stamping/stamper.sh ? Or is there a more native alternative for stamping?

Fixes bazel-contrib#47

Signed-off-by: psalaberria002 <psalaberria002@gmail.com>
@thesayyn
Copy link
Collaborator

I haven't thought about stamping much. let's split labels and stamping into their own PRs. I'd like to have a solid implementation for stamping and support config_setting at the same time.

@psalaberria002
Copy link
Contributor Author

I haven't thought about stamping much. let's split labels and stamping into their own PRs. I'd like to have a solid implementation for stamping and support config_setting at the same time.

Fair enough. Let me remove the stamping part.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@thesayyn
Copy link
Collaborator

looks like you need to run bazel run //docs:update

@psalaberria002
Copy link
Contributor Author

looks like you need to run bazel run //docs:update

Done.

@thesayyn thesayyn merged commit 7ce5875 into bazel-contrib:main Feb 24, 2023
@thesayyn
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oci_image should support adding labels
3 participants