Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use digest when loading image unto daemon #79

Merged
merged 3 commits into from
Mar 7, 2023
Merged

fix: use digest when loading image unto daemon #79

merged 3 commits into from
Mar 7, 2023

Conversation

thesayyn
Copy link
Collaborator

No description provided.

@thesayyn thesayyn mentioned this pull request Feb 25, 2023
Merged
@thesayyn thesayyn enabled auto-merge (squash) February 25, 2023 00:13
@thesayyn thesayyn changed the title fix: handle __main__ and no package gracefully fix: strip illegal characters before constructing default tag Mar 2, 2023
@thesayyn thesayyn requested review from alexeagle and removed request for alexeagle March 3, 2023 13:29
alexeagle
alexeagle reviewed Mar 3, 2023
View reviewed changes
oci/private/structure_test.bzl Outdated Show resolved Hide resolved
oci/private/structure_test.bzl Outdated Show resolved Hide resolved
@thesayyn thesayyn changed the title fix: strip illegal characters before constructing default tag fix: use digest when loading image unto daemon Mar 7, 2023
@thesayyn thesayyn requested a review from alexeagle March 7, 2023 15:50
alexeagle
alexeagle reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I think this is a regression.

previously you could write some user instructions like
bazel build :some-image; podman run bazel/some-image:latest
but now you can't predict it anymore

@thesayyn
Copy link
Collaborator Author

thesayyn commented Mar 7, 2023

we have oci_tarball for that and people should use that since images guaranteed to have tags you specify via repotags attribute.

@thesayyn thesayyn merged commit 7ab19ac into main Mar 7, 2023
@thesayyn thesayyn deleted the workspace_name branch March 7, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesayyn @alexeagle