Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: point to js example in rules_js #80

Merged
merged 3 commits into from
Feb 28, 2023
Merged

chore: point to js example in rules_js #80

merged 3 commits into from
Feb 28, 2023

Conversation

alexeagle
Copy link
Collaborator

The one here is bound to go out-of-date.

@alexeagle
chore: point to js example in rules_js
6a0717b 
The one here is bound to go out-of-date.
@alexeagle
refactor: move language docs to docs folder
41431a5 
These don't have any code with them so they aren't examples.
@alexeagle
Copy link
Collaborator Author

@thesayyn I think removing that CI step is fine since we have the same coverage in structure_tests - does that sound right to you?

@thesayyn
Copy link
Collaborator

thesayyn commented Feb 27, 2023 •
edited
Loading

that'd probably be fine though but we lose coverage for oci_tarball. It could be better to make it a sh_test but if you don't have the time, I'd be fine with addressing it later after filing an issue.

@alexeagle alexeagle merged commit c49a4ff into main Feb 28, 2023
@alexeagle alexeagle deleted the doc_js branch February 28, 2023 13:36
alexeagle pushed a commit that referenced this pull request Mar 12, 2023
@HoloRin
Add rules_erlang 2.5.2 (#80)
4771330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @thesayyn