fix: remove use of label ctor in repo rule impl to avoid restarts #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattem this generally looks good to me, just needs fixing up so it passes CI |
|
🤦 missed the commit of the typo fix. |
jsharpe
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of the
Labelconstructor used for templating with a predeclared dependency on the files as private rule attrs. This removes the need for Skyframe to restart the rule each time a new dependency is encountered during the running of the repository rule.From running
bazel test //...in the test directory before this change:Where as the profile after shows just the single invocation.
This is a similar issue we caught in rules_nodejs, bazel-contrib/rules_nodejs#2621 and there's further context in bazelbuild/bazel#16162