Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency rules_cc to v0.0.13 #389

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore(deps): update dependency rules_cc to v0.0.13 #389

wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 13, 2024 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
rules_cc bazel_dep patch 0.0.9 -> 0.0.13
rules_cc http_archive patch 0.0.9 -> 0.0.13

Release Notes

bazelbuild/rules_cc (rules_cc)

v0.0.13

Compare Source

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.13/rules_cc-0.0.13.tar.gz"],
    sha256 = "d9bdd3ec66b6871456ec9c965809f43a0901e692d754885e89293807762d3d80",
    strip_prefix = "rules_cc-0.0.13",
)
What's Changed
New Contributors

Full Changelog: bazelbuild/rules_cc@0.0.12...0.0.13

v0.0.12

Compare Source

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.12/rules_cc-0.0.12.tar.gz"],
    sha256 = "b26168b9a13f094794982b832975eaf53cefc5dced5b3be7df6b8b794dc2744b",
    strip_prefix = "rules_cc-0.0.12",
)

Full Changelog: bazelbuild/rules_cc@0.0.11...0.0.12

v0.0.11

Compare Source

Loading rules_cc
load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.11/rules_cc-0.0.11.tar.gz"],
    sha256 = "7e2a1f6c5dd908e6e88d7c80257c99d14e16fa985b56342287fddb6a32c435b5",
    strip_prefix = "rules_cc-0.0.11",
)
What's Changed
New Contributors

Full Changelog: bazelbuild/rules_cc@0.0.10...0.0.11

v0.0.10

Compare Source

What's Changed

Full Changelog: bazelbuild/rules_cc@0.0.9...0.0.10

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.10/rules_cc-0.0.10.tar.gz"],
    sha256 = "65b67b81c6da378f136cc7e7e14ee08d5b9375973427eceb8c773a4f69fa7e49",
    strip_prefix = "rules_cc-0.0.10",
)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/rules_cc-0.x branch 2 times, most recently from c2f564d to 9959a8f Compare September 23, 2024 09:28
@renovate renovate bot force-pushed the renovate/rules_cc-0.x branch 4 times, most recently from 23180f5 to 1a5dc3a Compare October 6, 2024 16:51
@renovate renovate bot changed the title chore(deps): update dependency rules_cc to v0.0.10 chore(deps): update dependency rules_cc to v0.0.11 Oct 7, 2024
@renovate renovate bot changed the title chore(deps): update dependency rules_cc to v0.0.11 chore(deps): update dependency rules_cc to v0.0.12 Oct 7, 2024
@renovate renovate bot force-pushed the renovate/rules_cc-0.x branch 4 times, most recently from a8b9115 to 0db6c77 Compare October 9, 2024 17:34
@renovate renovate bot changed the title chore(deps): update dependency rules_cc to v0.0.12 chore(deps): update dependency rules_cc Oct 9, 2024
@renovate renovate bot changed the title chore(deps): update dependency rules_cc chore(deps): update dependency rules_cc to v0.0.13 Oct 10, 2024
@renovate renovate bot force-pushed the renovate/rules_cc-0.x branch 2 times, most recently from a18fb89 to dbaa74a Compare October 11, 2024 18:58
@rrbutani rrbutani enabled auto-merge (squash) October 11, 2024 18:59
@renovate renovate bot force-pushed the renovate/rules_cc-0.x branch 2 times, most recently from 72b15d7 to 5f2d592 Compare October 11, 2024 20:55
@rrbutani
Copy link
Collaborator

rrbutani commented Oct 11, 2024 •
edited
Loading

Tests are failing because we (currently) aim to support Bazel 7.0 and rules_cc recently inherited @bazel_tools//cpp:* stuff from Bazel at HEAD:

The problematic change for us is cc_configure's use of reproducible on module_ctx.extension_metadata (added here in bazelbuild/bazel#22335) which wasn't added until bazelbuild/bazel#20272 (7.1.0).

I assume we want to update rules_cc to gate the reproducible argument using bazel_features instead of bumping our minimum supported Bazel version?

cc: @fmeum

edit: filed bazelbuild/rules_cc#254

rrbutani added a commit to rrbutani/rules_cc that referenced this pull request Oct 11, 2024
@rrbutani
extensions: gate module_ctx.extension_metadata(reproducible = ...) …
14a11be 
…appropriately

`reproducible` was added in Bazel 7.1.0; gating this argument allows
older Bazel versions to use rules_cc 0.0.13 and newer.

Note that this change (use of `reproducible`) came from Bazel itself in
bazelbuild/bazel#22335; it made its way over to `rules_cc` via
bazelbuild@c2549f6
(see bazelbuild/bazel@1c4e78a).

More context [here](bazel-contrib/toolchains_llvm#389 (comment)).
@rrbutani rrbutani mentioned this pull request Oct 11, 2024
Closed
@rrbutani rrbutani marked this pull request as draft October 11, 2024 21:24
rrbutani added a commit to rrbutani/rules_cc that referenced this pull request Oct 11, 2024
@rrbutani
extensions: gate module_ctx.extension_metadata(reproducible = ...) …
55fc267 
…appropriately

`reproducible` was added in Bazel 7.1.0; gating this argument allows
older Bazel versions to use rules_cc 0.0.13 and newer.

Note that this change (use of `reproducible`) came from Bazel itself in
bazelbuild/bazel#22335; it made its way over to `rules_cc` via
bazelbuild@c2549f6
(see bazelbuild/bazel@1c4e78a).

More context [here](bazel-contrib/toolchains_llvm#389 (comment)).
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 11, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rrbutani

This comment was marked as resolved.

Sign in to view
@fmeum
Copy link
Member

fmeum commented Oct 12, 2024

I'll look into the rules_cc failures. In WORKSPACE land, it should depend on protobuf via its legacy name com_google_protobuf.

@fmeum fmeum mentioned this pull request Oct 12, 2024
Open
@fmeum
Copy link
Member

fmeum commented Oct 12, 2024

Sent bazelbuild/rules_cc#255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrbutani rrbutani Awaiting requested review from rrbutani rrbutani is a code owner

@jsharpe jsharpe Awaiting requested review from jsharpe jsharpe is a code owner

@fmeum fmeum Awaiting requested review from fmeum fmeum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrbutani @fmeum