Skip to content

Commit

Permalink
Change the default value of `experimental_remote_cache_compression_th…
Browse files Browse the repository at this point in the history
…reshold` to `100`.

Based on discussions in bazelbuild#18997, `~100` is the break even point where the compression actually helps the builds.

RELNOTES: The default value of `--experimental_remote_cache_compression_threshold` is changed to `100`.
PiperOrigin-RevId: 670948584
Change-Id: I33ef54e84d68da5df5526a95cd9b7d94e746c9b5
  • Loading branch information
coeuvre authored and copybara-github committed Sep 4, 2024
1 parent 384e381 commit f6a55c3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,9 @@ public RemoteBuildEventUploadModeConverter() {

@Option(
name = "experimental_remote_cache_compression_threshold",
defaultValue = "0",
// Based on discussions in #18997, `~100` is the break even point where the compression
// actually helps the builds.
defaultValue = "100",
documentationCategory = OptionDocumentationCategory.REMOTE,
effectTags = {OptionEffectTag.UNKNOWN},
help =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1242,6 +1242,7 @@ public void compressedDownloadBlobIsRetriedWithProgress()
throws IOException, InterruptedException {
RemoteOptions options = Options.getDefaults(RemoteOptions.class);
options.cacheCompression = true;
options.cacheCompressionThreshold = 0;
final GrpcCacheClient client = newClient(options);
final Digest digest = DIGEST_UTIL.computeAsUtf8("abcdefg");
ByteString chunk1 = ByteString.copyFrom(Zstd.compress("abc".getBytes(UTF_8)));
Expand Down

0 comments on commit f6a55c3

Please sign in to comment.