Update to use Xcode 15.2 #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/update-to-xcode-15
branch
from
90dc76a
to
fac5b2a
Compare
luispadron
added a commit
that referenced
this pull request
Feb 29, 2024
This is a pre-req to #837 since `visionos` is not in 6.3.x
luispadron
force-pushed
the
luis/update-to-xcode-15
branch
3 times, most recently
from
9e0020d
to
0baee3a
Compare
luispadron
added a commit
that referenced
this pull request
Feb 29, 2024
This is a pre-requisite for Xcode 15+ adoption (#837). Supported versions are available here: https://developer.apple.com/support/xcode/ Changes: - Update to add more minimum OS versions - Update iOS versions <12.0 to use 12.0 - Update macOS versions <10.13 to use 10.13 - Update test host app versions to drop OS < 12.0
luispadron
force-pushed
the
luis/update-to-xcode-15
branch
6 times, most recently
from
b2652c7
to
2948ee4
Compare
luispadron
commented
Mar 1, 2024
| @@ -32,7 +32,7 @@ def xcspec_from_file(path): | |||
| eval_bzl_path = sys.argv[4] | |||
| xcode = os.path.dirname(os.path.dirname(developer_dir)) | |||
| xcode_plugins = os.path.join( | |||
| xcode, "Contents/PlugIns/XCBSpecifications.ideplugin/Contents/Resources" | |||
| xcode, "Contents/Developer/Library/Xcode/Plug-ins/XCBSpecifications.ideplugin/Contents/Resources" | |||
There was a problem hiding this comment.
This is the new path to XCBSpecifications.ideplugin
luispadron
commented
Mar 1, 2024
| with ctxlock: | ||
| self.status = -1 | ||
| self.status = -1 |
There was a problem hiding this comment.
Unrelated but ctxlock is undefined so when a lldb test would fail this would mask the actual error.
luispadron
commented
Mar 1, 2024
tests/macos/xcconfig/tests.bzl
Outdated
There was a problem hiding this comment.
These changes were required after updating xcspecs, they don't really make sense to me but 🤷🏼
|
Once this merges i'll mark the 15.2 jobs required in GitHub again |
luispadron
force-pushed
the
luis/update-to-xcode-15
branch
from
2948ee4
to
4c81ddd
Compare
|
|
mattrobmattrob
approved these changes
Mar 1, 2024
luispadron
force-pushed
the
luis/update-to-xcode-15
branch
from
4c81ddd
to
d00b344
Compare
|
Got past the build failure by updating the sim to use iPhone 15, now just need to update the fixtures for arm64 since |
luispadron
force-pushed
the
luis/update-to-xcode-15
branch
from
d00b344
to
8f990bc
Compare
jszumski
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for Bazel 7 (#795).
Changes: