Update rules for ObjcProvider deprecations #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
2 times, most recently
from
54f23fd
to
d120169
Compare
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
6 times, most recently
from
89d3b46
to
b25d77a
Compare
luispadron
changed the base branch from
master
to
luis/update-transition_support
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
3 times, most recently
from
1418b1a
to
476584a
Compare
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
2 times, most recently
from
a1761ca
to
2cdd6ee
Compare
jszumski
reviewed
Mar 27, 2024
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
4 times, most recently
from
d04484b
to
4dcd8ac
Compare
jszumski
approved these changes
Apr 3, 2024
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
2 times, most recently
from
1fe8de7
to
cf1ba61
Compare
luispadron
force-pushed
the
luis/update-ccinfo-for-objc-provider-deprecation
branch
from
5513720
to
4b4fad7
Compare
jszumski
approved these changes
Apr 15, 2024
thiagohmcruz
approved these changes
Apr 18, 2024
luispadron
added a commit
that referenced
this pull request
Apr 18, 2024
thiagohmcruz
added a commit
that referenced
this pull request
Jun 5, 2024
Can be considered a follow up to #850 to fix `import_middleman` in Bazel 7 while keeping it backwards compatible with Bazel 6.
nataliejameson
pushed a commit
to discord/rules_ios
that referenced
this pull request
Aug 13, 2024
Can be considered a follow up to bazel-ios/rules_ios#850 to fix `import_middleman` in Bazel 7 while keeping it backwards compatible with Bazel 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Bazel 7+
ObjcProviderno longer supports/provides the required linking attributes.The migrations is detailed here: bazelbuild/bazel#16939. In summary, as part of the migration, the
ObjcProviderfields which previously provided linking related information are now now longer providing that info. In addition to this, a new flag:--incompatible_objc_linking_info_migrationwas added to further delete these link attrs from theObjcProvidermaking it an error if the attr is used or set.The goal of this PR is to address support for
ObjcProvidermigration and to instead use the correct linking information fromCcInfo. This will support both Bazel 6/7+. It does not try to support--incompatible_objc_linking_info_migrationas that requires more changes and should be a separate PRDepends on: