Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost.config@1.86.0 #2700

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Boost.config@1.86.0 #2700

wants to merge 9 commits into from
+96 −1

Conversation

Vertexwahn
Copy link
Contributor

Boost.config@1.86.0

@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config) have been updated in this PR. Please review the changes.

wep21
wep21 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci.

bazel-io
bazel-io approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Sep 1, 2024
fmeum
fmeum reviewed Sep 1, 2024
View reviewed changes
modules/boost.config/1.86.0/overlay/BUILD.bazel
],
),
features = [
"parse_headers",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the headers are not meant to be included and should be moved into textual_hdrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

@bazel-io bazel-io bazel-io approved these changes

@wep21 wep21 wep21 approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vertexwahn @bazel-io @fmeum @wep21