Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Gazelle to Go import_alias naming convention #861

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Migrate Gazelle to Go import_alias naming convention #861

merged 2 commits into from
Aug 7, 2020

Conversation

jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Aug 7, 2020 •
edited
Loading

  • Set naming convention in main build file.
  • Add gazelle:repository declarations in WORKSPACE for repos in gazelle_dependencies.
  • Run 'gazelle fix'.
  • Manual fixes for manually written targets.

For #5

Jay Conrod added 2 commits August 7, 2020 13:54
all: migrate build files to go_import_alias naming convention
27639a5
all: declare deps with gazelle:repository directive
17527ff 
This tells the resolver that these are go_repository rules with the
default naming convention (import_alias), which simplifies labels in
deps in a few places.
@jayconrod jayconrod merged commit 570264c into bazelbuild:go_naming_convention Aug 7, 2020
@jayconrod jayconrod deleted the migrate-names branch August 7, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayconrod