Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clang_debian8 and clang_ubuntu16_04 base images (r340178) #178

Closed
wants to merge 2 commits into from
Closed

Update clang_debian8 and clang_ubuntu16_04 base images (r340178) #178

wants to merge 2 commits into from

Conversation

alex1545
Copy link
Contributor

@alex1545 alex1545 commented Sep 5, 2018

  • Update clang_debian8 base image (r340178)
  • Update clang_ubuntu16_04 base image (r340178)

xingao267
xingao267 reviewed Sep 5, 2018
View reviewed changes
rules/toolchain_containers.bzl Outdated
@@ -24,7 +24,7 @@ def toolchain_container_sha256s():
# Clang images #
###########################################################
# gcr.io/cloud-marketplace/google/clang-debian8:r337145
"debian8_clang": "sha256:de1116d36eafe16890afd64b6bc6809a3ed5b3597ed7bc857980749270894677",
"debian8_clang": "sha256:0946899544c00537b2af06790e72ba86aa39b16e0e05aef8f53ed79d1f89f2a0",
# gcr.io/cloud-marketplace/google/clang-ubuntu:r337145
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the tag of r337145 here and above.

@xingao267
Copy link
Member

xingao267 commented Sep 5, 2018 •
edited
Loading

The //test/configs:debian8_clang_autoconfig_test failed with the following error:

diff -ry --suppress-common-lines /b/s/w/ir/run/_tmp/910f818f9eb9fd2c8f577bdb8821c74d/local_config_cc/CROSSTOOL /b/s/w/ir/run/_tmp/910f818f9eb9fd2c8f577bdb8821c74d/bazel-toolchains-44200e0c026d86c53470d107b3697a3e46469c43/configs/debian8_clang/0.3.0/bazel_0.10.0/CROSSTOOL
--
  | cxx_builtin_include_directory: "/usr/local/lib/clang/8.0.0/ \|	  cxx_builtin_include_directory: "/usr/local/lib/clang/7.0.0/
  |  

It's because we update the clang container, and now it's generating configs with clang 0.8.0, but the test is checking for 0.7.0. I'll make a PR to include this change and a container that pin to a specific sha soly for testing purpose.

I'm gonna close this PR as it's a little too involving to make that change atm. Will cc you in the new change.

@xingao267 xingao267 closed this Sep 5, 2018
@alex1545 alex1545 deleted the clang-base-images-update-r340178 branch September 7, 2018 22:05
freeformstu pushed a commit to freeformstu/bazel-toolchains that referenced this pull request Nov 11, 2023
Update LLVM version in tests to 15 (bazelbuild#178)
82b448b 
External tests still need to be on 14, because of crashes in some tests
with LLVM 15.

Suse tests work with LLVM 13 now, so they have been re-enabled
(fixes bazelbuild#143).

For macOS, Intel binaries are available only for 15.0.7, but for Linux,
binaries are available only for 15.0.6. So we now include a mechanism to
provide different version strings for different {os, arch} pair.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingao267 xingao267 xingao267 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex1545 @xingao267