Skip to content

Commit

Permalink
Merge with 6.3.0 baseline.
Browse files Browse the repository at this point in the history
Particularly manually merge relevant signature changes from
1cd3588. Thsi
is different than
1cd3588
itself because that also uses a baseline too new for 6.3.0.
  • Loading branch information
gregestren committed Jul 12, 2023
1 parent 856662a commit 069a50c
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,10 @@ public void handleConvenienceSymlinks(AnalysisResult analysisResult) {
ImmutableList<ConvenienceSymlink> convenienceSymlinks = ImmutableList.of();
if (request.getBuildOptions().experimentalConvenienceSymlinks
!= ConvenienceSymlinksMode.IGNORE) {
convenienceSymlinks = createConvenienceSymlinks(request.getBuildOptions(), analysisResult);
convenienceSymlinks = createConvenienceSymlinks(
request.getBuildOptions(),
analysisResult.getTargetsToBuild(),
analysisResult.getConfigurationCollection().getTargetConfiguration());
}
if (request.getBuildOptions().experimentalConvenienceSymlinksBepEvent) {
env.getEventBus().post(new ConvenienceSymlinksIdentifiedEvent(convenienceSymlinks));
Expand All @@ -729,7 +732,9 @@ public void handleConvenienceSymlinks(AnalysisResult analysisResult) {
* in fact gets removed if it was already present from a previous invocation.
*/
private ImmutableList<ConvenienceSymlink> createConvenienceSymlinks(
BuildRequestOptions buildRequestOptions, AnalysisResult analysisResult) {
BuildRequestOptions buildRequestOptions,
ImmutableSet<ConfiguredTarget> targetsToBuild,
BuildConfigurationValue configuration) {
SkyframeExecutor executor = env.getSkyframeExecutor();
Reporter reporter = env.getReporter();

Expand Down

0 comments on commit 069a50c

Please sign in to comment.