Specializes the getBatchAsync method for dep prefetching.

PiperOrigin-RevId: 213183365
bazelbuild · Sep 16, 2018 · 5233993 · 5233993
1 parent 1f08d4c
commit 5233993
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/main/java/com/google/devtools/build/skyframe/QueryableGraph.java b/src/main/java/com/google/devtools/build/skyframe/QueryableGraph.java
@@ -60,6 +60,12 @@ public interface QueryableGraph {
     return InterruptibleSupplier.Memoize.of(() -> getBatch(requestor, reason, keys));
   }
 
+  /** Optimistically prefetches dependencies. */
+  default void prefetchDeps(@Nullable SkyKey requestor, Iterable<? extends SkyKey> depKeys)
+      throws InterruptedException {
+    getBatchAsync(requestor, Reason.PREFETCH, depKeys);
+  }
+
   /**
    * Examines all the given keys. Returns an iterable of keys whose corresponding nodes are
    * currently available to be fetched.

diff --git a/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java b/src/main/java/com/google/devtools/build/skyframe/SkyFunctionEnvironment.java
@@ -212,10 +212,8 @@ private Map<SkyKey, SkyValue> batchPrefetch(
         depKeysAsSet = depKeys.toSet();
         evaluatorContext
             .getGraph()
-            .getBatchAsync(
-                requestor,
-                Reason.PREFETCH,
-                Iterables.filter(oldDeps, Predicates.not(Predicates.in(depKeysAsSet))));
+            .prefetchDeps(
+                requestor, Iterables.filter(oldDeps, Predicates.not(Predicates.in(depKeysAsSet))));
       }
     }
     Map<SkyKey, ? extends NodeEntry> batchMap =