Remove "windows_tests" and "all_windows_tests" targets from BUILD files

After 572d4fd, we no longer rely on those targets to run Windows tests on Bazel CI. This also simplify the process to enable your tests on Windows when creating a new package (boilerplate targets are no longer needed). Related #4292 Closes #13608. PiperOrigin-RevId: 381841867
bazelbuild · Jun 28, 2021 · 7ce19e4 · 7ce19e4
1 parent ae81f95
commit 7ce19e4
Show file tree

Hide file tree

Showing 99 changed files with 0 additions and 1,580 deletions.
diff --git a/src/BUILD b/src/BUILD
@@ -483,36 +483,6 @@ genrule(
     visibility = ["//:__pkg__"],
 )
 
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-        "//src/test/cpp:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/lib:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/skyframe:all_windows_tests",
-        "//src/test/java/com/google/devtools/common/options:all_windows_tests",
-        "//src/test/native/windows:all_windows_tests",
-        "//src/test/py/bazel:all_windows_tests",
-        "//src/test/res:all_windows_tests",
-        "//src/test/shell:all_windows_tests",
-        "//src/test/shell/bazel/android:all_windows_tests",
-        "//src/tools/launcher:all_windows_tests",
-        "//src/tools/singlejar:all_windows_tests",
-        "//third_party/def_parser:all_windows_tests",
-        "//tools:all_windows_tests",
-    ],
-)
-
 # config_setting alias left here because bazel-only third_party code is pointing to it
 alias(
     name = "windows",

diff --git a/src/test/cpp/BUILD b/src/test/cpp/BUILD
@@ -120,21 +120,3 @@ cc_test(
 )
 
 test_suite(name = "all_tests")
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-        "//src/test/cpp/util:all_windows_tests",
-    ],
-    visibility = ["//src:__pkg__"],
-)
diff --git a/src/test/cpp/util/BUILD b/src/test/cpp/util/BUILD
@@ -143,20 +143,3 @@ cc_library(
 )
 
 test_suite(name = "all_tests")
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/cpp:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/BUILD b/src/test/java/com/google/devtools/build/android/BUILD
@@ -350,26 +350,3 @@ java_library(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-        "//src/test/java/com/google/devtools/build/android/desugar:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/dexer:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/idlclass:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/junctions:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/resources:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/ziputils:all_windows_tests",
-    ],
-    visibility = ["//src:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/desugar/BUILD b/src/test/java/com/google/devtools/build/android/desugar/BUILD
@@ -2108,27 +2108,6 @@ java_binary(
     ],
 )
 
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-        "//src/test/java/com/google/devtools/build/android/desugar/classes_for_testing_type_inference:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/desugar/dependencies:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/desugar/io:all_windows_tests",
-        "//src/test/java/com/google/devtools/build/android/desugar/runtime:all_windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)
-
 java_test(
     name = "ClassSignatureParserTest",
     size = "small",

diff --git a/...t/java/com/google/devtools/build/android/desugar/classes_for_testing_type_inference/BUILD b/...t/java/com/google/devtools/build/android/desugar/classes_for_testing_type_inference/BUILD
@@ -19,20 +19,3 @@ java_import(
     name = "test_subjects",
     jars = ["test_subjects.jar"],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android/desugar:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/desugar/dependencies/BUILD b/src/test/java/com/google/devtools/build/android/desugar/dependencies/BUILD
@@ -28,19 +28,3 @@ java_test(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android/desugar:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/desugar/io/BUILD b/src/test/java/com/google/devtools/build/android/desugar/io/BUILD
@@ -37,19 +37,3 @@ java_test(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android/desugar:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD b/src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD
@@ -113,20 +113,3 @@ java_test(
         "//third_party:junit4",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android/desugar:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/dexer/BUILD b/src/test/java/com/google/devtools/build/android/dexer/BUILD
@@ -90,20 +90,3 @@ java_library(
     name = "mixed_testinput",
     srcs = [":mixed_srcjar_gen"],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/idlclass/BUILD b/src/test/java/com/google/devtools/build/android/idlclass/BUILD
@@ -24,20 +24,3 @@ java_test(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/junctions/BUILD b/src/test/java/com/google/devtools/build/android/junctions/BUILD
@@ -29,20 +29,3 @@ java_test(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/r8/BUILD b/src/test/java/com/google/devtools/build/android/r8/BUILD
@@ -90,20 +90,3 @@ java_library(
     name = "dexmergersample",
     srcs = glob(["testdata/dexmergersample/*.java"]),
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/resources/BUILD b/src/test/java/com/google/devtools/build/android/resources/BUILD
@@ -26,20 +26,3 @@ java_test(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/testing/manifestmerge/BUILD b/src/test/java/com/google/devtools/build/android/testing/manifestmerge/BUILD
@@ -19,20 +19,3 @@ filegroup(
         "merger/AndroidManifest.xml",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android/testing:__pkg__"],
-)
diff --git a/src/test/java/com/google/devtools/build/android/ziputils/BUILD b/src/test/java/com/google/devtools/build/android/ziputils/BUILD
@@ -27,20 +27,3 @@ java_test(
         "//third_party:truth",
     ],
 )
-
-test_suite(
-    name = "windows_tests",
-    tags = [
-        "-no_windows",
-        "-slow",
-    ],
-    visibility = ["//visibility:private"],
-)
-
-test_suite(
-    name = "all_windows_tests",
-    tests = [
-        ":windows_tests",
-    ],
-    visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
-)