Skip to content

Commit

Permalink
windows,tests: enable some tests on Windows
Browse files Browse the repository at this point in the history
Add ":windows_tests" and ":all_windows_tests"
rules to these packages, and include them in the
parent packages.

Fixes #4127
See #4292

Change-Id: I9c454ed21f47feb8e88e1c25b1e4fa216baa38f6
PiperOrigin-RevId: 181951525
  • Loading branch information
laszlocsomor authored and Copybara-Service committed Jan 15, 2018
1 parent f071102 commit 8d41822
Show file tree
Hide file tree
Showing 10 changed files with 126 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1968,6 +1968,7 @@ test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
"//src/test/java/com/google/devtools/build/android/desugar/classes_for_testing_type_inference:all_windows_tests",
"//src/test/java/com/google/devtools/build/android/desugar/dependencies:all_windows_tests",
"//src/test/java/com/google/devtools/build/android/desugar/runtime:all_windows_tests",
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,20 @@ java_import(
name = "test_subjects",
jars = ["test_subjects.jar"],
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/build/android/desugar:__pkg__"],
)
5 changes: 5 additions & 0 deletions src/test/java/com/google/devtools/build/lib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1477,16 +1477,21 @@ test_suite(
tests = [
":windows_tests",
"//src/test/java/com/google/devtools/build/lib/analysis/platform:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/analysis/skylark/annotations/processor:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/analysis/whitelisting:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/bazel/repository:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/buildeventservice:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/buildeventstream/transports:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/buildtool:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/profiler/callcounts:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/profiler/memory:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/rules/android:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/rules/apple:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/rules/config:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/rules/cpp:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/rules/platform:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/rules/repository:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/shell:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/skyframe:all_windows_tests",
"//src/test/java/com/google/devtools/build/lib/skylark:all_windows_tests",
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,20 @@ filegroup(
name = "ProcessorTestFiles",
srcs = glob(["optiontestsources/*.java"]),
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/build/lib:__pkg__"],
)
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,20 @@ java_test(
"//third_party/pprof:profile_java_proto",
],
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/build/lib:__pkg__"],
)
17 changes: 17 additions & 0 deletions src/test/java/com/google/devtools/build/lib/profiler/memory/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,20 @@ java_test(
"//third_party/pprof:profile_java_proto",
],
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/build/lib:__pkg__"],
)
17 changes: 17 additions & 0 deletions src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,20 @@ java_library(
"//third_party/protobuf/3.4.0:protobuf_java",
],
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/build/lib:__pkg__"],
)
17 changes: 17 additions & 0 deletions src/test/java/com/google/devtools/build/lib/shell/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,20 @@ cc_binary(
name = "killmyself",
srcs = ["killmyself.cc"],
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/build/lib:__pkg__"],
)
1 change: 1 addition & 0 deletions src/test/java/com/google/devtools/common/options/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
"//src/test/java/com/google/devtools/common/options/processor:all_windows_tests",
"//src/test/java/com/google/devtools/common/options/testing:all_windows_tests",
],
visibility = ["//src:__pkg__"],
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/com/google/devtools/common/options/processor/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,20 @@ filegroup(
name = "OptionTestFiles",
srcs = glob(["optiontestsources/*.java"]),
)

test_suite(
name = "windows_tests",
tags = [
"-no_windows",
"-slow",
],
visibility = ["//visibility:private"],
)

test_suite(
name = "all_windows_tests",
tests = [
":windows_tests",
],
visibility = ["//src/test/java/com/google/devtools/common/options:__pkg__"],
)

0 comments on commit 8d41822

Please sign in to comment.