Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1 - January 2020 (stable) #10132

Closed
dslomov opened this issue Oct 30, 2019 · 25 comments
Closed

Release 2.1 - January 2020 (stable) #10132

dslomov opened this issue Oct 30, 2019 · 25 comments
Assignees
Labels

Comments

@dslomov
Copy link
Contributor

dslomov commented Oct 30, 2019

Cut date: 2020-01-07

@laurentlb laurentlb self-assigned this Nov 4, 2019
@jin jin pinned this issue Jan 7, 2020
@c16a
Copy link

c16a commented Jan 8, 2020

Hope 934c4fd is included in this change?

@laurentlb
Copy link
Contributor

laurentlb commented Jan 8, 2020

Status of Bazel 2.1

To report a release-blocking bug, please file a bug using the Release blocker label, and cc me.

Task list:

@laurentlb
Copy link
Contributor

All changes submitted before today should be included.
I'll update the previous status message later today.

@Yannic
Copy link
Contributor

Yannic commented Jan 14, 2020

Could we cherry-pick 4162cc5 into Bazel 2.1? (Context: #10484)

@werkt
Copy link
Contributor

werkt commented Jan 14, 2020

Requesting cherry-pick of 9a823d9 into Bazel 2.1 (Context: #10566), addresses a NPE resulting in build failures.

@meteorcloudy
Copy link
Member

Please cherry-pick 7e4c9d5 to fix #10572

@Helcaraxan
Copy link

For those not following the GitHub issue in question but #10356, which was re-opened yesterday, might be considered a release-blocker for 2.1.0.

@keith
Copy link
Member

keith commented Jan 22, 2020

Any plans for when there will be another RC or the official 2.1.0 release?

@laurentlb
Copy link
Contributor

I'll make another RC tomorrow.

@laurentlb
Copy link
Contributor

I'm waiting for a resolution on #10356.

Apart from that, I'll cherry-pick:

Please tell me if I forgot another one. In some cases, I commented on the issue why I don't think a fix qualifies for a cherry-pick. Let me know if you feel strongly otherwise.

@philwo
Copy link
Member

philwo commented Jan 29, 2020

Just mentioning this here, so it doesn't get lost: This commit 2a8cc70 is the cherry-pick for #10356.

@laurentlb
Copy link
Contributor

Sorry for the delay, I have been busy with some emergencies.

I've just tried to create rc2 with:
scripts/release/release.sh create --force_rc=2 2.1.0 41ec5a2 733ac0f c94b147 2a8cc70

But this is currently failing: bazelbuild/continuous-integration#929

@philwo
Copy link
Member

philwo commented Jan 30, 2020

I fixed the release pipeline so the error bazelbuild/continuous-integration#929 should no longer happen. We build Bazel with Xcode 10.3 now. I verified that the resulting binary still works fine on macOS High Sierra, so we don't regress in that regard.

Please cherry-pick this commit to fix a potential security issue that I accidentally introduced (it would have been in rc2, so let's skip that one) and then we can do rc3: d381c25

@laurentlb
Copy link
Contributor

laurentlb commented Jan 30, 2020

Creating candidate with:

scripts/release/release.sh create --force_rc=3 2.1.0 41ec5a2 733ac0f c94b147 2a8cc70 bdf34d7 d381c25

scripts/release/release.sh create --force_rc=4 2.1.0 41ec5a2 733ac0f c94b147 2a8cc70 bdf34d7 d381c25 eab39cc

(bdf34d7 was added to avoid a merge conflict)

@laurentlb
Copy link
Contributor

Although there are still some issues in our testing infrastructure, the binaries can be tried here:
https://releases.bazel.build/2.1.0/rc4/index.html

@laurentlb
Copy link
Contributor

The release announcement is ready: bazelbuild/bazel-blog#216

I'll do the release tomorrow.

@philwo
Copy link
Member

philwo commented Feb 13, 2020

I'm preparing Bazel 2.1.1 with one cherry-pick:

9a823d9: Prevent NPE on backwards seek on Chunker.

RELEASE_NUMBER=2.0.1
BASELINE_COMMIT=50514fc6c125750d7063d7feea2c302a44d2db6e
git clone https://github.com/bazelbuild/bazel.git ~/bazel-release-$RELEASE_NUMBER
cd ~/bazel-release-$RELEASE_NUMBER
scripts/release/release.sh create $RELEASE_NUMBER $BASELINE_COMMIT
9a823d9

@philwo
Copy link
Member

philwo commented Feb 13, 2020

Bazel 2.1.1rc1 is now available for those that want to try it out.

You can download it from:
https://releases.bazel.build/2.1.1/rc1/index.html

@werkt
Copy link
Contributor

werkt commented Feb 19, 2020

I've tested the rc, and it works precisely how we hoped with my change. Can this be promoted to a full release?

@philwo
Copy link
Member

philwo commented Feb 19, 2020

@werkt I'll push it out tomorrow morning.

@werkt
Copy link
Contributor

werkt commented Feb 20, 2020

Any news on that release?

@philwo
Copy link
Member

philwo commented Feb 21, 2020

@werkt Pushing it now. Sorry for the delay. 😬

@or-shachar
Copy link
Contributor

What about a docker image l.gcr.io/google/bazel:2.1.1 ? :-) who's in charge of those releases?

@laurentlb laurentlb unpinned this issue Mar 9, 2020
@jin
Copy link
Member

jin commented Apr 24, 2020

Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests