Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxing time breakdown in tracing profile needed #10404

Closed
ob opened this issue Dec 12, 2019 · 3 comments
Closed

Sandboxing time breakdown in tracing profile needed #10404

ob opened this issue Dec 12, 2019 · 3 comments
Assignees
Labels
team-Performance Issues for Performance teams

Comments

@ob
Copy link
Contributor

ob commented Dec 12, 2019

As discussed at BazelCon, debugging the sandbox performance problem on macOS would be easier if there was an option to add to the trace profile a break down, per action, of the time it takes to set up the sandbox, the time it takes to execute the action’s command, and the time it takes to tear down the sandbox.

meisterT added a commit to meisterT/bazel that referenced this issue Dec 12, 2019
@meisterT meisterT self-assigned this Dec 12, 2019
@meisterT meisterT added the team-Performance Issues for Performance teams label Dec 12, 2019
@ob
Copy link
Contributor Author

ob commented Dec 17, 2019

@meisterT, I just got around to trying this... but I'm not sure what I should be seeing. I ran bazel as

bazel build --genrule_strategy=sandboxed --spawn_strategy=sandboxed --config Debug --experimental_generate_json_trace_profile --experimental_profile_cpu_usage --profile trace-profile.json //:App

And got this:
Screen Shot 2019-12-17 at 9 57 21 AM

I was expecting something more like this:
Screen Shot 2019-12-17 at 9 57 21 AM

@meisterT
Copy link
Member

It's there, it's just super small :-)

See my screenshots:
xea2ruxP3vA

Same action, zoomed in:
ajBOOnULB0v

So the super thin blue bars are the sandboxing setup.

@meisterT
Copy link
Member

I just realized that this just the Java object creation. I'll create a follow-up commit...

@meisterT meisterT reopened this Dec 17, 2019
meisterT added a commit to meisterT/bazel that referenced this issue Dec 17, 2019
The previous attempt only accounted for the object creation but not the
actual sandbox setup.

Fix bazelbuild#10404.

RELNOTES: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Performance Issues for Performance teams
Projects
None yet
2 participants