Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"test" exec group fails to properly inherit from default exec group #13459

Closed
katre opened this issue May 10, 2021 · 2 comments
Closed

"test" exec group fails to properly inherit from default exec group #13459

katre opened this issue May 10, 2021 · 2 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: bug

Comments

@katre
Copy link
Member

katre commented May 10, 2021

(This is a copy of an internal issue that was filed on 2021/03/20).

Exec group inheritance is complicated, and does not correctly inherit from the default exec group properties when they come from the execution platform.

The fix involves a large rework of exec group inheritance, which is currently in progress.
@katre katre added type: bug P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions labels May 10, 2021
@katre katre self-assigned this May 10, 2021
@katre
Copy link
Member Author

katre commented May 10, 2021

Previous commits in the fix:

  • dcceaa3: Split ExecGroup into a new target
  • 64534e2: Move DEFAULT_EXEC_GROUP_NAME from ToolchainCollection to ExecGroup
  • 9b18d95: Rename ToolchainCollection.getExecGroups to getExecGroupNames
  • 762b5d8: BuildViewForTesting should directly call into ConfiguredTargetFunction
  • a116649: Move exec group tests out of platforms_test and into integration
  • afba8ac: Update creating exec groups that explicitly copy from defaults

@katre
Copy link
Member Author

katre commented May 10, 2021

There are a few more commits coming to finish this fix.

@katre katre mentioned this issue May 10, 2021
Closed
@quval quval mentioned this issue Jun 7, 2021
Closed
9 tasks
katre added a commit to katre/bazel that referenced this issue Jul 13, 2021
@katre
Create a new ExecGroupCollection container to manage exec group inher…
8c6382a 
…itance and exec property parsing.

Fixes bazelbuild#13459.

PiperOrigin-RevId: 373388266
@katre katre mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre