Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete header information from ObjcProvider #14559

Closed
googlewalt opened this issue Jan 12, 2022 · 0 comments
Closed

Delete header information from ObjcProvider #14559

googlewalt opened this issue Jan 12, 2022 · 0 comments
Assignees

Comments

@googlewalt
Copy link
Contributor

googlewalt commented Jan 12, 2022

In #10674 we had migrated the header information used for compilation from ObjcProvider to CcInfo, but we still left the direct header information in ObjcProvider, primarily for the use of our internal IDEs. But CcInfo has direct header information also, so the ObjcProvider information is largely redundant, and users should migrate to the direct header APIs in CcCompilationContext.

We plan to delete the direct header information in ObjcProvider. This will also allow us to delete some cumbersome APIs that have remained just to support that. ObjcProvider's direct_sources will remain, and continue to contain headers from the srcs attribute.

Starlark rules should be migrated for this change as follows:

  1. Migrate uses of ObjcProvider's direct_headers to CcCompilationContext. ObjcProvider's direct_headers corresponds to CcCompilationContext's direct_public_headers plus direct_textual_headers. Related, CcCompilationContext also provides direct_private_headers and direct_headers.

  2. Delete any header parameters to apple_common.new_objc_provider().

@googlewalt googlewalt self-assigned this Jan 12, 2022
@sventiffe sventiffe added team-Rules-CPP Issues for C++ rules untriaged labels Jan 13, 2022
mattrobmattrob added a commit to mattrobmattrob/rules_ios that referenced this issue Nov 28, 2022
mattrobmattrob added a commit to mattrobmattrob/rules_ios that referenced this issue Nov 28, 2022
mattrobmattrob added a commit to mattrobmattrob/rules_ios that referenced this issue Dec 1, 2022
mattrobmattrob added a commit to mattrobmattrob/rules_ios that referenced this issue Dec 3, 2022
mattrobmattrob added a commit to bazel-ios/rules_ios that referenced this issue Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants